[pxt] Fix deprecation of "out" option in tsconfigs #9492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
May 2, 2023
This was referenced May 2, 2023
kimprice
reviewed
May 2, 2023
| @@ -1553,7 +1553,7 @@ function buildFolderAndBrowserifyAsync(p: string, optional?: boolean, outputName | |||
|
|
|||
| const tsConfig = JSON.parse(fs.readFileSync(path.join(p, "tsconfig.json"), "utf8")); | |||
| if (outputName && tsConfig.compilerOptions.outDir !== `../built/${outputName}`) { | |||
| U.userError(`${p}/tsconfig.json expected compilerOptions.ourDir:"../built/${outputName}", got "${tsConfig.compilerOptions.outDir}"`); | |||
There was a problem hiding this comment.
Was this just an old typo?
There was a problem hiding this comment.
yep. very old typo :)
kimprice
approved these changes
May 2, 2023
jwunderl
pushed a commit
that referenced
this pull request
Aug 8, 2023
jwunderl
added a commit
that referenced
this pull request
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript 5.0 deprecates tsconfig's "out" compiler option in favor of "outFile". Even though we don't yet use TS5, VSCode recently started flagging this as an error in some of pxt's tsconfig.json files. This is a fix to remedy that. This change must also be made in all target repos, and pxt-arcade-sim.
Reference: microsoft/TypeScript#51909